-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use single source of truth for sensitive config items #31820
Use single source of truth for sensitive config items #31820
Conversation
Previously we had them defined both in constant and in config.yml. Now just config.yml This change does however cause config.yml to be loaded when the sensitive_config_values property is accessed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lazy loading that means it should only matter when someone hits the config page right? Seems good to me - that is as long as we ship the config yaml in the dist, but I'm not sure if we do or don't
ah yes, at first glance i thought this property might have gotten loaded up every time airflow conf got loaded but, i think you're right it's only invoked via webserver / configuration view so i think performance of loading the yaml is non-issue |
Previously we had them defined both in constant and in config.yml. Now just config.yml (cherry picked from commit cab342e)
Previously we had them defined both in constant and in config.yml.
Now just config.yml
This change does however cause config.yml to be loaded when the sensitive_config_values property is accessed.